Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit_prelaunch: Load configuration before Erlang dist. is started #2378

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

dumbbell
Copy link
Member

The reason is that kernel's net_ticktime can be configured in the Cuttlefish or Erlang configuration files. If we start the distribution first, then the configuration parameter is ignored.

Fixes #2377.

The reason is that kernel's `net_ticktime` can be configured in the
Cuttlefish or Erlang configuration files. If we start the distribution
first, then the configuration parameter is ignored.

Fixes #2377.
@dumbbell dumbbell added this to the 3.8.5 milestone Jun 10, 2020
@dumbbell dumbbell requested a review from lukebakken June 10, 2020 08:57
@dumbbell dumbbell self-assigned this Jun 10, 2020
@dumbbell dumbbell marked this pull request as ready for review June 10, 2020 13:06
@michaelklishin michaelklishin removed this from the 3.8.5 milestone Jun 10, 2020
@michaelklishin
Copy link
Member

Please don't add milestones to PRs that have corresponding issues.

Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested with the following configuration file and 90 second ticktime is applied -

rabbitmq.conf.txt

without this PR, the ticktime remains at 60 seconds

@dumbbell
Copy link
Member Author

Thank you!

@dumbbell dumbbell merged commit e61c608 into master Jun 10, 2020
@dumbbell dumbbell deleted the load-conf-before-erlang-dist-setup branch June 10, 2020 14:32
@michaelklishin
Copy link
Member

@michaelklishin
Copy link
Member

Package and upgrade tests are also green.

michaelklishin pushed a commit that referenced this pull request Jun 11, 2020
…etup

rabbit_prelaunch: Load configuration before Erlang dist. is started

(cherry picked from commit e61c608)
@michaelklishin
Copy link
Member

Backported to v3.8.x.

@dumbbell dumbbell modified the milestone: 3.8.5 Jun 11, 2020
@dumbbell
Copy link
Member Author

Thank you @michaelklishin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configured net_ticktime is ignored in RabbitMQ 3.8.4
3 participants