Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restart of stream coordinator when there are no stream queues #3170

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix restart of stream coordinator when there are no stream queues #3170

merged 1 commit into from
Jul 5, 2021

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Jul 1, 2021 •
edited

Other test fixes

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@dcorbacho dcorbacho requested a review from kjnilsson July 5, 2021 12:54
@dcorbacho dcorbacho changed the title WIP: Fix restart of stream coordinator when there are no stream queues Fix restart of stream coordinator when there are no stream queues Jul 5, 2021
kjnilsson
kjnilsson approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change even if it doesn't improve test flakyness

Fix restart of stream coordinator when there are no stream queues
deaa42e 
Recovering from an existing queue is fine but if a node is restarted when
there are no longer stream queues on the system, the recovery process won't
restart the pre-existing coordinator as that's only performed on queue recovery.
The first attempt to declare a new stream queue on this cluster will crash with
`coordinator unavailable` error, as it only restarts the local coordinator
and not the whole ra cluster, thus lacking quorum.

Recovering the coordinator during the boot process ensures that a pre-existing
coordinator cluster is restarted in any case, and does nothing if there was
never a coordinator on the node.
@kjnilsson kjnilsson merged commit 284809e into master Jul 5, 2021
@michaelklishin michaelklishin deleted the stream-flaky branch July 27, 2021 08:40
pjk25 pushed a commit that referenced this pull request Jul 27, 2021
@kjnilsson @pjk25
Merge pull request #3170 from rabbitmq/stream-flaky
dad4e70 
Fix restart of stream coordinator when there are no stream queues

(cherry picked from commit 284809e)
@pjk25
Copy link
Contributor

pjk25 commented Jul 27, 2021

Backported to v3.9.x dad4e70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjnilsson kjnilsson kjnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcorbacho @pjk25 @kjnilsson