Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public umbrella repo mention from CONTRIBUTING guide. #3172

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

deadtrickster
Copy link
Collaborator

Proposed Changes

Since plugins moved in the main repo umbrella us no longer needed to build.
Therefore update CONTRIBUTING guide

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

I see there are lots of bazel scripts here and there, Should they (or bazel in general) be mentioned in the guide too?

@michaelklishin michaelklishin merged commit c87117c into master Jul 2, 2021
@michaelklishin michaelklishin deleted the update-contributing-guide branch July 2, 2021 14:39
michaelklishin added a commit that referenced this pull request Jul 2, 2021
Remove public umbrella repo mention from CONTRIBUTING guide.

(cherry picked from commit c87117c)
michaelklishin added a commit that referenced this pull request Jul 2, 2021
Remove public umbrella repo mention from CONTRIBUTING guide.

(cherry picked from commit c87117c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants