Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "store" instead of "commit" for offset tracking #3177

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Use "store" instead of "commit" for offset tracking #3177

merged 1 commit into from
Jul 13, 2021

Conversation

acogoluegnes
Copy link
Contributor

No description provided.

@gerhard
Copy link
Contributor

gerhard commented Jul 8, 2021

This looks good! Should anything introduced in the rabbitmq CLI part of #3043 be revised part of this too?

@acogoluegnes
Copy link
Contributor Author

Good point. The committed_offset in the stream_status command is the chunk id (= first offset in the chunk) of the last (stored) chunk, so the committed offset for the replication replication. So this should not be changed, because it's not the same concept as the stored offset for consumer tracking.

This is committed_offset that triggered a discussion to change "commit" to "store" for consumer tracking.

@pjk25 pjk25 merged commit 860333a into master Jul 13, 2021
@pjk25 pjk25 deleted the stream-commit-offset-becomes-store-offset branch July 13, 2021 10:11
@pjk25
Copy link
Contributor

pjk25 commented Jul 13, 2021 •
edited

This should be backported to the v3.9.x branch before 3.9 goes GA.

michaelklishin pushed a commit that referenced this pull request Jul 13, 2021
@pjk25 @michaelklishin
Merge pull request #3177 from rabbitmq/stream-commit-offset-becomes-s…
5681510 
…tore-offset

Use "store" instead of "commit" for offset tracking

(cherry picked from commit 860333a)
@michaelklishin
Copy link
Member

Backported to v3.9.x.

@michaelklishin michaelklishin added this to the 3.9.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acogoluegnes @gerhard @pjk25 @michaelklishin