Fix channel rate limiter for ack messages #3230
Conversation
|
@acogoluegnes I have updated some test timeouts based on the failures in the checks. A rebase should pick them up without conflict. |
acogoluegnes
force-pushed
the
fix-notify-limiter
branch
from
a6f591d
to
4486584
Compare
Because of a regression in 3.9.x. References rabbitmq/rabbitmq-server#3230
Because of a regression in 3.9.x. References rabbitmq/rabbitmq-server#3230 (cherry picked from commit 559c4cb)
Because of a regression in 3.9.x. References rabbitmq/rabbitmq-server#3230 (cherry picked from commit 559c4cb)
|
This looks good to me. I kicked off the jobs again as there were failures in the last run. As soon as everything goes green, this is good to merge and backport to Does this need backporting to |
|
I think this is specific to |
|
@pjk25 does this fail often? Should we just re-run? https://github.com/rabbitmq/rabbitmq-server/pull/3230/checks?check_run_id=3172111643#step:4:1487 |
It looks like the only hard failure was for |
|
The timeout for //deps/rabbit:unit_disk_monitor_mocks_SUITE has been adjusted in master with 68361d5 |
|
FYI I have clicked re-run as it seemed the most expedient way to address the failure. Should we hit another timeout, I would advise correcting it in master and rebasing this branch to pick up both corrections. |
Fix channel rate limiter for ack messages (cherry picked from commit 1b5c7e3)
|
Backported to |
No description provided.