Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash on badarg when env file has certain Unicode characters #3239

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

deadtrickster
Copy link
Collaborator

closes #3212

Proposed Changes

As proposed by @lhoguin, converting using unicode:characters_to_binary helps.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

deps/rabbit_common/src/rabbit_env.erl Outdated Show resolved Hide resolved
deps/rabbit_common/src/rabbit_env.erl Outdated Show resolved Hide resolved
@deadtrickster deadtrickster force-pushed the some-sort-of-unicode-support-in-env-files branch from 03d97cb to 854f26a Compare July 28, 2021 14:39
@michaelklishin michaelklishin changed the title Do not crash on badarg when env file has an 'unusual' unicode character Do not crash on badarg when env file has certain Unicode characters Jul 28, 2021
@michaelklishin michaelklishin merged commit 1596f03 into master Jul 28, 2021
@michaelklishin michaelklishin deleted the some-sort-of-unicode-support-in-env-files branch July 28, 2021 20:18
michaelklishin added a commit that referenced this pull request Jul 28, 2021
…n-env-files

Do not crash on badarg when env file has certain Unicode characters

(cherry picked from commit 1596f03)
michaelklishin added a commit that referenced this pull request Jul 28, 2021
…n-env-files

Do not crash on badarg when env file has certain Unicode characters

(cherry picked from commit 1596f03)
@michaelklishin
Copy link
Member

Backported to v3.9.x.

@michaelklishin
Copy link
Member

Backported to v3.8.x.

@michaelklishin michaelklishin added this to the 3.8.20 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode character in HOSTNAME prevents RabbitMQ from starting
4 participants