Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebar3_hex plugin reference to rebar3.config generated by erlang.mk #3247

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

deadtrickster
Copy link
Collaborator

@deadtrickster deadtrickster commented Jul 29, 2021

This allows erlang.mk hex publish target to progress beyond ===> Command hex not found error

@gerhard gerhard merged commit 5f639fa into master Jul 29, 2021
@gerhard gerhard deleted the add-rebar3_hex_to_auto-generated-rebar3-config branch July 29, 2021 11:10
@gerhard
Copy link
Contributor

gerhard commented Jul 29, 2021

Forgot to add the backport v3.9.x label before closing this. Doing it manually now, but will remember to add it next time.

gerhard added a commit that referenced this pull request Jul 29, 2021
…ed-rebar3-config

Add rebar3_hex plugin reference to rebar3.config generated by erlang.mk

(cherry picked from commit 5f639fa)
gerhard added a commit that referenced this pull request Jul 29, 2021
…ed-rebar3-config

Add rebar3_hex plugin reference to rebar3.config generated by erlang.mk

(cherry picked from commit 5f639fa)
@gerhard
Copy link
Contributor

gerhard commented Jul 29, 2021

Backported to v3.9.x & v3.8.x

@michaelklishin
Copy link
Member

We should perhaps upstream this? @dumbbell @lhoguin

@deadtrickster
Copy link
Collaborator Author

Turns out we don't use bare rebar3, but our own wrapper - hexpm-cli, It has hardcoded config with rebar3_hex. I created PR to upgrade it to recent rebar3 with OTP 24 support - rabbitmq/hexpm-cli#2

@lhoguin
Copy link
Contributor

lhoguin commented Jul 30, 2021

For the record: no this kind of change should not be added to Erlang.mk. Erlang.mk produces a rebar.config file that's meant to be used for projects used as dependencies. There is no problem in that case because the plugins can be added to the top-level rebar.config file.

@dumbbell
Copy link
Member

Also, erlang.mk is a generated file. We should revert this change now instead of being caught by surprise with some obscure regressions when we update Erlang.mk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants