Fix store offset parameters #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you can see https://github.com/rabbitmq/rabbitmq-server/blob/860333a08816e05749ebfbdad32a7da66d5c9b3f/deps/rabbitmq_stream_common/src/rabbit_stream_core.erl#L239 There is the stream name and not the subscription id in this message.
|
Good catch, thanks! |
|
@Mergifyio backport v3.9.x |
|
Command
|
acogoluegnes
added a commit
that referenced
this pull request
Sep 2, 2021
Fix store offset parameters (backport #3360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see
rabbitmq-server/deps/rabbitmq_stream_common/src/rabbit_stream_core.erl
Line 239 in 860333a
There is the stream name and not the subscription id in this message.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply