Fix win32 memory leak by using raw file operations
#3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/fix-mem-leak
branch
from
ca58de5
to
a0a8b59
Compare
lhoguin
approved these changes
Dec 17, 2021
|
The commit title is a bit inaccurate as we were already using prim_file which is essentially the same as a raw operation. It would be better to describe that you are using read instead of read_file. |
|
could the leak be in |
|
@jhogberg figured it out in record time - erlang/otp#5527 |
|
@lhoguin I will rewrite the commit message, thanks for pointing that out. |
|
@kjnilsson that's what I originally thought but it's not the FHC. |
lukebakken
force-pushed
the
lukebakken/fix-mem-leak
branch
from
a0a8b59
to
20977f6
Compare
lukebakken
force-pushed
the
lukebakken/fix-mem-leak
branch
from
3323b5b
to
365de60
Compare
|
@lhoguin @michaelklishin I'll re-test this on my Windows system today, then I'll move it out of draft. |
|
|
michaelklishin
approved these changes
Dec 19, 2021
michaelklishin
added a commit
that referenced
this pull request
Dec 19, 2021
Fix win32 memory leak by using `raw` file operations (backport #3906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal but this skips all file servers.