Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream coordinator: avoid mnesia update process crashing after delete #3908

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Stream coordinator: avoid mnesia update process crashing after delete #3908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 15 additions & 11 deletions deps/rabbit/src/rabbit_stream_coordinator.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,18 +846,22 @@ phase_update_mnesia(StreamId, Args, #{reference := QName,
%% This can happen during recovery
%% we need to re-initialise the queue record
%% if the stream id is a match
[Q] = mnesia:dirty_read(rabbit_durable_queue, QName),
case amqqueue:get_type_state(Q) of
#{name := S} when S == StreamId ->
rabbit_log:debug("~s: initializing queue record for stream id ~s",
[?MODULE, StreamId]),
_ = rabbit_amqqueue:ensure_rabbit_queue_record_is_initialized(Fun(Q)),
case mnesia:dirty_read(rabbit_durable_queue, QName) of
[] ->
%% queue not found at all, it must have been deleted
ok;
_ ->
ok
end,

send_self_command({mnesia_updated, StreamId, Args});
[Q] ->
case amqqueue:get_type_state(Q) of
#{name := S} when S == StreamId ->
rabbit_log:debug("~s: initializing queue record for stream id ~s",
[?MODULE, StreamId]),
_ = rabbit_amqqueue:ensure_rabbit_queue_record_is_initialized(Fun(Q)),
ok;
_ ->
ok
end,
send_self_command({mnesia_updated, StreamId, Args})
end;
_ ->
send_self_command({mnesia_updated, StreamId, Args})
catch _:E ->
Expand Down