Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some logging timestamps #4277

Merged
merged 1 commit into from Mar 16, 2022
Merged

Update some logging timestamps #4277

merged 1 commit into from Mar 16, 2022

Conversation

lukebakken
Copy link
Collaborator

@lukebakken
Update some logging timestamps
455c01f 
Uses the same format as the OTP logger

Fixes #4276
@lukebakken lukebakken self-assigned this Mar 15, 2022
@lukebakken
Copy link
Collaborator Author

@davidydang

Here's what a logged trace message looks like with this patch. Note the updated timestamp in RFC 3339 format, including TZ offset:

================================================================================
2022-03-15T12:53:17.680-07:00: Message published

Node:         rabbit@bakkenl-z01
Connection:   <rabbit@bakkenl-z01.1647373428.2088.0>
Virtual host: /
User:         guest
Channel:      1
Exchange:     
Routing keys: [<<"tracing-test">>]
Routed queues: [<<"tracing-test">>]
Properties:   [{<<"delivery_mode">>,signedint,2},{<<"headers">>,table,[]}]
Payload: 
SOTEUOSENTHU

@davidydang
Copy link

It looks nice. Thank you Luck for your quick response.

@michaelklishin michaelklishin merged commit 8dae5d3 into master Mar 16, 2022
@michaelklishin michaelklishin deleted the rabbitmq-server-4276 branch March 16, 2022 13:45
@mergify mergify bot mentioned this pull request Mar 16, 2022
Merged
lukebakken added a commit that referenced this pull request Mar 16, 2022
@lukebakken
Merge pull request #4278 from rabbitmq/mergify/bp/v3.10.x/pr-4277
7f708b3 
Update some logging timestamps (backport #4277)
@lukebakken
Copy link
Collaborator Author

@davidydang the fix will be available in RabbitMQ 3.10 and later.

@davidydang
Copy link

Thank you very much. Look forward the release.

lukebakken added a commit that referenced this pull request Mar 22, 2022
@lukebakken
Fix return value of now_to_str
b3c35b4 
Prior to 331ff8e the print/2 function was used to format output which also converted to binary. This restores the conversion to binary.

Follow up to #4277 and #4278
@lukebakken lukebakken mentioned this pull request Mar 22, 2022
Merged
lukebakken added a commit that referenced this pull request Mar 22, 2022
@lukebakken
Update 3.10.0.md
57daf40 
Follow-up to the following:

#4276
#4277
#4329
@lukebakken lukebakken mentioned this pull request Mar 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 22, 2022
@lukebakken
Fix return value of now_to_str
077583e 
Prior to 331ff8e the print/2 function was used to format output which also converted to binary. This restores the conversion to binary.

Follow up to #4277 and #4278

(cherry picked from commit b3c35b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rabbitmq_tracing does not use local time zone for timestamps
3 participants
@lukebakken @davidydang @michaelklishin