No longer file:allocate CQv2 index files #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The property suite has found issues. Will investigate tomorrow. |
essen
force-pushed
the
loic-dont-allocate-cqv2-index
branch
from
88aa4bb
to
e09906c
Compare
|
I have fixed the property suite, it was missing a case clause during recovery. |
|
This is both an alternative fix for #4721 and an improvement to the way v2 index segment files are handled: we no longer pre-allocate the files, so there is no platform differences anymore (there was for at least Windows and FreeBSD+ZFS), and the files do not unnecessarily take space on disk. |
michaelklishin
added a commit
that referenced
this pull request
May 6, 2022
No longer file:allocate CQv2 index files (backport #4735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack following #4721.
This is both an alternative fix for #4721 and an improvement to the way v2 index segment files are handled: we no longer pre-allocate the files, so there is no platform differences anymore (there was for at least Windows and FreeBSD+ZFS), and the files do not unnecessarily take space on disk.