Preserve heartbeat error reason #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://groups.google.com/g/rabbitmq-users/c/gRURlk9E6M0 In the above thread, the user experienced a heartbeat send timeout that was logged as `{inet_error, timeout}`. The only way to know this was related to heartbeats was to reproduce the issue and do a debug trace. After this change, the error message will be as follows: ``` 2022-12-20 08:57:12.614470-08:00 [error] <0.959.0> closing AMQP connection <0.959.0> (127.0.0.1:52052 -> 127.0.0.1:5672): 2022-12-20 08:57:12.614470-08:00 [error] <0.959.0> {inet_error,{heartbeat_send_error,timeout}} ``` I grepped the code for cases where `inet_error` is caught. The one place where this happens is compatible with the change in this patch.
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2022
Preserve heartbeat error reason (backport #6708)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://groups.google.com/g/rabbitmq-users/c/gRURlk9E6M0
In the above thread, the user experienced a heartbeat send timeout that was logged as
{inet_error, timeout}. The only way to know this was related to heartbeats was to reproduce the issue and do a debug trace. After this change, the error message will be as follows:I grepped the code for cases where
inet_erroris caught. The one place where this happens is compatible with the change in this patch.