Move missing Mnesia-specific code to rabbit_db_* modules #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorbacho
force-pushed
the
rabbit-db-modules
branch
4 times, most recently
from
a34bb4f
to
eca6557
Compare
dcorbacho
changed the title
dcorbacho
force-pushed
the
rabbit-db-modules
branch
17 times, most recently
from
5497aaf
to
f2efeb0
Compare
dcorbacho
force-pushed
the
rabbit-db-modules
branch
3 times, most recently
from
4d0ad07
to
dcd1ee8
Compare
dcorbacho
force-pushed
the
rabbit-db-modules
branch
4 times, most recently
from
3337f69
to
97a084c
Compare
the-mikedavis
previously approved these changes
Feb 1, 2023
There was a problem hiding this comment.
I gave this another read through and it looks good to me. I'm not super familiar with the server codebase though so take my review with a grain of salt.
I like seeing the direct mnesia calls and match-specs moved into db modules, it feels more clean (even independent of the upcoming khepri changes) 👍
dcorbacho
force-pushed
the
rabbit-db-modules
branch
from
97a084c
to
9cf10ed
Compare
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
May 31, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
May 31, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
May 31, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
May 31, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
May 31, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
Jun 1, 2023
ansd
added a commit
to rabbitmq/rabbitmq-lvc-exchange
that referenced
this pull request
Jun 1, 2023
due to rabbitmq/rabbitmq-server#6821 (cherry picked from commit 72b970c)
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work started in #6430
The idea is to isolate in those modules the code to handle the records in the database. For now, we only support Mnesia, but there is work in progress to move to another database engine. Doing this reorganization of the code will also isolate the changes of this upcoming database engine switch, making them easier to rebase and review.