Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit_feature_flags: Fix formatting of the logged list of feature flags (backport #7232) #7233

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 9, 2023

This is an automatic backport of pull request #7232 done by Mergify.
Cherry-pick of 10d3242 has failed:

On branch mergify/bp/v3.11.x/pr-7232
Your branch is up to date with 'origin/v3.11.x'.

You are currently cherry-picking commit 10d3242133.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/src/rabbit_ff_registry_factory.erl

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Feb 9, 2023
The backport change from `master` was badly adapted to `v3.11.x`,
leading to "FORMATTER CRASH" messages. This commit fixes that.

While here, use `io_lib:format/2` instead of `rabbit_misc:format/2` as
we do a `lists:flatten/1` in the end anyway.

(cherry picked from commit 10d3242)
@dumbbell dumbbell removed the conflicts label Feb 9, 2023
@dumbbell dumbbell added this to the 3.11.9 milestone Feb 9, 2023
@dumbbell dumbbell merged commit 7d3f96a into v3.11.x Feb 9, 2023
@dumbbell dumbbell deleted the mergify/bp/v3.11.x/pr-7232 branch February 9, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant