Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 2549: auth_oauth2.preferred_username_claims should accept multiple values #7458

Merged
merged 2 commits into from Feb 28, 2023
Merged

Fixes 2549: auth_oauth2.preferred_username_claims should accept multiple values #7458

merged 2 commits into from Feb 28, 2023

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Feb 28, 2023 •
edited by michaelklishin

Proposed changes

  • auth_oauth2.preferred_username_claims should accept multiple values
  • Use new config style on two selenium test suites
  • Test oauth2 backend's config schema and oauth2 management config schema

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Notes for reviewer

This PR is accompanied by another docs's PR.

Fixes #2549.

@MarcialRosales
Fix 2549
efb1b5b 
Allow list of preferred_username_claims in cuttlefish
config style.
Use new config style on two selenium test suites
Test oauth2 backend's config schema and oauth2 management
config schema
@MarcialRosales MarcialRosales self-assigned this Feb 28, 2023
@michaelklishin michaelklishin merged commit 203b5bd into main Feb 28, 2023
@michaelklishin michaelklishin deleted the fix-2549 branch February 28, 2023 16:19
@mergify mergify bot mentioned this pull request Feb 28, 2023
Merged
michaelklishin added a commit that referenced this pull request Feb 28, 2023
@michaelklishin
Merge pull request #7464 from rabbitmq/mergify/bp/v3.12.x/pr-7458
e2c1938 
Fix 2549 - auth_oauth2.preferred_username_claims should accept multiple values (backport #7458)
@michaelklishin michaelklishin added this to the 3.11.10 milestone Feb 28, 2023
michaelklishin added a commit that referenced this pull request Feb 28, 2023
@michaelklishin
Merge pull request #7466 from rabbitmq/mergify/bp/v3.11.x/pr-7464
bd97257 
Fix 2549 - auth_oauth2.preferred_username_claims should accept multiple values (backport #7458) (backport #7464)
michaelklishin added a commit that referenced this pull request Feb 28, 2023
@michaelklishin
Merge pull request #7468 from rabbitmq/mergify/bp/v3.10.x/pr-7466
1cc4e4d 
Fix 2549 - auth_oauth2.preferred_username_claims should accept multiple values (backport #7458) (backport #7464) (backport #7466)
@michaelklishin michaelklishin changed the title Fix 2549 - auth_oauth2.preferred_username_claims should accept multiple values Fixes 2549: auth_oauth2.preferred_username_claims should accept multiple values Mar 1, 2023
@Radiergummi
Copy link

Awesome to see this minor issue addressed so soon. Thank you very much for your work on RabbitMQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@MarcialRosales MarcialRosales

Labels
backport-v3.11.x backport-v3.12.x
Projects
None yet
Milestone
3.11.10
Development

Successfully merging this pull request may close these issues.

Evaluate what settings can be exposed using new style configuration
3 participants
@MarcialRosales @Radiergummi @michaelklishin