Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid an exception during client connection with some environments, fixes #7787 #7788

Merged
merged 3 commits into from Mar 31, 2023
Merged

Avoid an exception during client connection with some environments, fixes #7787 #7788

merged 3 commits into from Mar 31, 2023

Conversation

lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Mar 31, 2023 •
edited by michaelklishin

Fixes #7787.

lhoguin and others added 3 commits March 31, 2023 10:20
@lhoguin
Use addr from #connection directly
2a8b9ea
@michaelklishin
Connection limit: don't do anything if the limit is not configured
f75e205 
In rabbit_reader:is_over_connection_limit/2.

References #7753, #7787, #7593.
@lhoguin
Keep Ranch ref in rabbit_reader v1 record
d3129d9 
This is used to check if we're over connection limit and avoids
risky attempts to retrieve the ref from socket host/port.
@michaelklishin michaelklishin changed the title Tentative fix for #7787 Avoid an exception during client connection with some environments, fixes #7787 Mar 31, 2023
@michaelklishin michaelklishin added this to the 3.11.13 milestone Mar 31, 2023
@michaelklishin michaelklishin marked this pull request as ready for review March 31, 2023 10:14
@michaelklishin michaelklishin mentioned this pull request Mar 31, 2023
Merged
12 tasks
@michaelklishin michaelklishin merged commit 48467d6 into v3.11.x Mar 31, 2023
16 checks passed
@michaelklishin michaelklishin deleted the lh-fix-max_conn-crash branch March 31, 2023 11:22
@michaelklishin
Copy link
Member

@Mergifyio backport v3.12.x main

@mergify
Copy link

mergify bot commented Mar 31, 2023 •
edited

backport v3.12.x main

✅ Backports have been created

This was referenced Mar 31, 2023
Merged
Merged
@SimonUnge
Copy link
Collaborator

Ah, my bad. I was unsure about getting the ranch_ref, thanks for the fix @lhoguin

@ikavgo ikavgo mentioned this pull request Nov 3, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhoguin @michaelklishin @SimonUnge