Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iptables calls with --wait #919

Merged
merged 1 commit into from Aug 16, 2016
Merged

Conversation

mwhahaha
Copy link

If iptables is currently being called outside of the ocf script, the
iptables call will fail because it cannot get a lock. This change
updates the iptables call to include the -w flag which will wait until
the lock can be established and not just exit with an error.

@michaelklishin
Copy link
Member

Thank you. If this is intended for the 3.6.x series, please re-submit (or submit another PR) against the stable branch.

@binarin @dmitrymex @bogdando can I have your blessing, please? :)

@mwhahaha
Copy link
Author

I'll submit another against the stable branch as well. Thanks.

If iptables is currently being called outside of the ocf script, the
iptables call will fail because it cannot get a lock. This change
updates the iptables call to include the -w flag which will wait until
the lock can be established and not just exit with an error.
@mwhahaha mwhahaha changed the title Update iptables calls with -w Update iptables calls with --wait Aug 15, 2016
@binarin
Copy link
Contributor

binarin commented Aug 16, 2016

LGTM

@michaelklishin michaelklishin self-assigned this Aug 16, 2016
@michaelklishin michaelklishin added this to the 3.7.0 milestone Aug 16, 2016
@michaelklishin michaelklishin merged commit e6c0ac0 into rabbitmq:master Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants