Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Valid dynamic Shovel properties can be rejected by validation #38

Closed
michaelklishin opened this issue Mar 29, 2018 · 1 comment · Fixed by #39
Closed

Valid dynamic Shovel properties can be rejected by validation #38

michaelklishin opened this issue Mar 29, 2018 · 1 comment · Fixed by #39
Assignees
@michaelklishin
Labels
bug effort-tiny
Milestone
3.7.5

Comments

@michaelklishin
Copy link
Member

See this rabbitmq-users thread.

This is the same general problem as in rabbitmq/rabbitmq-federation#67, rabbitmq/rabbitmq-federation#70: validation wasn't accepted to support/convert maps.
@michaelklishin michaelklishin added this to the 3.7.5 milestone Mar 29, 2018
@michaelklishin michaelklishin self-assigned this Mar 29, 2018
michaelklishin added a commit that referenced this issue Mar 29, 2018
@michaelklishin
Convert Shovel definitions to proplists before validating
2d73d97 
Validation historically expects proplists and doesn't handle
maps.

Closes #38.
[#156367916]
@michaelklishin michaelklishin mentioned this issue Mar 29, 2018
Merged
11 tasks
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Apr 24, 2018
@michaelklishin
One more place where a map definition must be converted to proplist b…
1788899 
…efore validation

Fixes rabbitmq/rabbitmq-management#565.

References #1493, rabbitmq/rabbitmq-federation#70,
           rabbitmq/rabbitmq-shovel#38, rabbitmq/rabbitmq-federation#73.

[#157045132]
This was referenced Apr 24, 2018
Merged
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue May 1, 2018
@michaelklishin
One more place where a map definition must be converted to proplist b…
069e58b 
…efore validation

Fixes rabbitmq/rabbitmq-management#565.

References #1493, rabbitmq/rabbitmq-federation#70,
           rabbitmq/rabbitmq-shovel#38, rabbitmq/rabbitmq-federation#73.

[#157045132]

(cherry picked from commit 1788899)
@michaelklishin michaelklishin modified the milestones: 3.7.5, 3.7.10 Nov 26, 2018
@michaelklishin
Copy link
Member Author

One commit from this wasn't backported from master in 3.7.5 and it happens to address #46.

michaelklishin added a commit that referenced this issue Nov 26, 2018
@michaelklishin
Convert Shovel definitions to proplists before validating
2ea4e7e 
Validation historically expects proplists and doesn't handle
maps.

Closes #38.
[#156367916]

(cherry picked from commit 2d73d97)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
bug effort-tiny
Projects
None yet
Milestone
3.7.5
Development

Successfully merging a pull request may close this issue.

Make dynamic Shovel definition validation support maps rabbitmq/rabbitmq-shovel
1 participant
@michaelklishin