-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRC32 checkSum control #285
Conversation
Fix application propriets in case of byte value Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 93.04% 92.84% -0.21%
==========================================
Files 110 112 +2
Lines 9640 9687 +47
Branches 764 769 +5
==========================================
+ Hits 8970 8994 +24
- Misses 511 531 +20
- Partials 159 162 +3
☔ View full report in Codecov by Sentry. |
replace copy with TryCopyTo to check if there are enough data to read. This will raise an Exception. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Currently evaluating this PR in our dev environments, looks good so far, no unexpected behaviours found, will continue to monitor for a couple of days |
@jonnepmyra thank you for following up, we really appreciate the feedback! |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
the CRC32 control. Add some crc32 test. Enable the CRC32 control on some consumer test Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than code and maintain our own Crc32 implementation, should we allow the user to provide one if they want this feature? i.e. if you want CRC32 checking, you must include one of these libraries with your application -
The idea was to reduce as much as possible the external dependencies. |
remove the old crc32 class Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
remove the old crc32 class Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gsantomaggio !!!
Crc32
interfaceRawConsumer:
By default, the CRC control is disabled to be compatible with the correct version.
Enable the CRC control could reduce the performances in some cases since it has to calculate the CRC for each chunk.
It is recommended to enable it.
The documentation needs to be included; once this is approved, we will update the documentation.