Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Producer/Consumer Identifier #348

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add Producer/Consumer Identifier #348

merged 2 commits into from
Jan 23, 2024

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jan 22, 2024

The Identifier helps to correlate the entities with the logs and the UI.

Add the Identifier for producer and consumer. For the consumer is visible in the UI, like:

Screenshot 2024-01-22 at 09 57 57

Code:

var producer = await Producer.Create(new ProducerConfig(system, stream)
{
   Identifier = $"my_producer_99",
                   

logs:

 ProducerInfo(Stream=my_stream, Reference=, Identifier=my_producer_99)

Note: The producer doesn't have custom properties so won't be showed on the UI.

The Identifier helps to correlate the entities with the logs and the UI.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (fa8f66b) 92.12% compared to head (e26dbae) 92.12%.

❗ Current head e26dbae differs from pull request most recent head b946c81. Consider uploading reports for the commit b946c81 to get more accurate results

Files Patch % Lines
RabbitMQ.Stream.Client/StreamSystem.cs 85.71% 0 Missing and 5 partials ⚠️
RabbitMQ.Stream.Client/IProducer.cs 25.00% 3 Missing ⚠️
RabbitMQ.Stream.Client/IConsumer.cs 50.00% 1 Missing ⚠️
RabbitMQ.Stream.Client/RawSuperStreamConsumer.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   92.12%   92.12%   -0.01%     
==========================================
  Files         116      116              
  Lines       11320    11366      +46     
  Branches      897      899       +2     
==========================================
+ Hits        10429    10471      +42     
- Misses        687      689       +2     
- Partials      204      206       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio added this to the 1.8.0 milestone Jan 22, 2024
@Gsantomaggio Gsantomaggio marked this pull request as ready for review January 22, 2024 17:35
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant