Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chunk info consumer side #355

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Add Chunk info consumer side #355

merged 3 commits into from
Feb 9, 2024

Conversation

Gsantomaggio
Copy link
Member

Closes #331

Closes #331

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio
Copy link
Member Author

@andreasolazzo-b52 @francescopessina87
Do you have the opportunity to test it?

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd8a4ce) 92.25% compared to head (ee794d0) 92.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   92.25%   92.05%   -0.21%     
==========================================
  Files         116      116              
  Lines       11728    11738      +10     
  Branches      916      916              
==========================================
- Hits        10820    10805      -15     
- Misses        700      726      +26     
+ Partials      208      207       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio changed the title Add Chuck info consumer side Add Chunk info consumer side Feb 8, 2024
@andreasolazzo-b52
Copy link

@andreasolazzo-b52 @francescopessina87 Do you have the opportunity to test it?

@Gsantomaggio @francescopessina87 and I tested it and it seems to be working as expected :)

@Gsantomaggio Gsantomaggio marked this pull request as ready for review February 9, 2024 06:53
@Gsantomaggio Gsantomaggio merged commit 66cbd13 into main Feb 9, 2024
2 checks passed
@Gsantomaggio Gsantomaggio deleted the expose_chunk_info branch February 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Chunk info to MessageContext
2 participants