-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All uris must be reachable in case of environment creation #309
Comments
Thank you @Egyptmaster yes, his part can be improved: rabbitmq-stream-go-client/pkg/stream/environment.go Lines 51 to 76 in 202c881
The client should try to connect with each URI |
Fixes: #309 Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
Fixes: #309 Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
Fixes: #309 Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
@Egyptmaster can you please try #310 ? thank you |
Sure, but can do on Monday earliest |
@Egyptmaster, please let me know if you have a chance to test it so I can release the new version. Thank you |
@Gsantomaggio sorry for late response. I recently tried the feature brach and the issue seems to be fixed 👍 |
* Fix multi uris connection * Fixes: #309 --------- Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
Describe the bug
Not sure if that is an expected behavior but it makes the usage of the client very hard. In case you are using multiple uris by
SetUris(uris ...string)
method all the hosts must be available at the point in time you create the environment withNewEnvironment
.Reproduction steps
will return an error in case one of the uris is not accessable at point in time
Expected behavior
From the documentation I would expect to silently accept one of the hosts/uris to be not available at any point in time and automatically use randomly another one. Otherwise it is really hard in context of kubernetes/docker when I can never guarantee that all nodes are available when my service tries to start.
Additional context
No response
The text was updated successfully, but these errors were encountered: