Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the ReliableProducer #267

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Improve the ReliableProducer #267

merged 4 commits into from
Feb 26, 2024

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio
Improve the ReliableProducer
6ddeee5 
- closes: #266
- part of: #265

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 79.82%. Comparing base (da27e0b) to head (e05eaf1).

Files Patch % Lines
pkg/stream/producer.go 55.17% 11 Missing and 2 partials ⚠️
pkg/stream/environment.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   79.98%   79.82%   -0.16%     
==========================================
  Files          18       18              
  Lines        2653     2677      +24     
==========================================
+ Hits         2122     2137      +15     
- Misses        382      389       +7     
- Partials      149      151       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio added this to the 1.4 milestone Feb 23, 2024
@Gsantomaggio
change the flushPendingMessages
e05eaf1 
with more info

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio merged commit 3db652a into main Feb 26, 2024
7 checks passed
@Gsantomaggio Gsantomaggio deleted the improve_timeout_confirm branch February 26, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

Implement confirmation timeout
1 participant
@Gsantomaggio