Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exchange version command #280

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add exchange version command #280

merged 1 commit into from
Mar 20, 2024

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Mar 20, 2024

Completes #278
Add the exchange commands
set if publish filter is supported or not

Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review March 20, 2024 14:10
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 86.90476% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.65%. Comparing base (328e304) to head (b060e9c).

Files Patch % Lines
pkg/stream/client.go 76.47% 4 Missing and 4 partials ⚠️
pkg/stream/server_frame.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   80.57%   80.65%   +0.08%     
==========================================
  Files          22       23       +1     
  Lines        2981     3061      +80     
==========================================
+ Hits         2402     2469      +67     
- Misses        417      426       +9     
- Partials      162      166       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio merged commit bfd81db into main Mar 20, 2024
4 checks passed
@Gsantomaggio Gsantomaggio deleted the exchange_version_command branch March 20, 2024 14:39
@Gsantomaggio Gsantomaggio added this to the 1.3.3 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant