Dispatch messages in dedicated thread #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each connection has now a dedicated single-threaded executor to dispatch messages. This is especially suited for long consumers, as they could block the handling of other frames sent by the server. Other server frames are now handled by a shared executor service. The default implementation maintains a list of executor services shared between all connections maintained by the environment instances. The list grows and shrinks depending on the usage.
acogoluegnes
added a commit
that referenced
this pull request
Mar 7, 2023
Executor services are now shared between connection, but there must be a distinction between producer and consumer connections, as a consumer can depend on a RPC in a producer connection (e.g. getting the stored offset from a connection to the stream leader). So the producer and consumer connections cannot share the same executors to avoid deadlocks. References #298
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
Executor services are now shared between connection, but there must be a distinction between producer and consumer connections, as a consumer can depend on a RPC in a producer connection (e.g. getting the stored offset from a connection to the stream leader). So the producer and consumer connections cannot share the same executors to avoid deadlocks. References #298
acogoluegnes
added a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each connection has now a dedicated single-threaded executor to dispatch messages. This is especially suited
for long consumers, as they could block the handling of other frames sent by the server.
Other server frames are now handled by a shared executor service. The default implementation maintains a list of executor services shared between all connections maintained by the environment instances. The list grows and shrinks depending on the usage.