Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None MessageResult, producer panic #162

Closed
51yu opened this issue Feb 20, 2023 · 7 comments · Fixed by #163
Closed

None MessageResult, producer panic #162

51yu opened this issue Feb 20, 2023 · 7 comments · Fixed by #163
Assignees
Labels
bug Something isn't working
Milestone

Comments

@51yu
Copy link

51yu commented Feb 20, 2023

producer panic if message result is None ..
https://github.com/rabbitmq/rabbitmq-stream-rust-client/blob/main/src/producer.rs#L556

it happen few minutes after app run, and app exit with panic
how to handle it gracefully without app panic ?

@wolf4ood
Copy link
Collaborator

Hi @51yu

thanks for raising this. So the basic step to reproduce it is to setup a producer and after few minutes it should panic right?

@wolf4ood wolf4ood self-assigned this Feb 20, 2023
@wolf4ood wolf4ood added the bug Something isn't working label Feb 20, 2023
@wolf4ood wolf4ood added this to the 0.1.1 milestone Feb 20, 2023
@51yu
Copy link
Author

51yu commented Feb 20, 2023

stacktrace

thread 'tokio-runtime-worker' panicked at 'not yet implemented', /rabbitmq-stream-client-0.1.0/src/producer.rs:558:21

<rabbitmq_stream_client::client::Client as rabbitmq_stream_client::client::handler::MessageHandler>::handle_message::{{closure}}::{{closure}}
             at rabbitmq-stream-client-0.1.0/src/client/mod.rs:100:81

@51yu
Copy link
Author

51yu commented Feb 20, 2023

Hi @51yu

thanks for raising this. So the basic step to reproduce it is to setup a producer and after few minutes it should panic right?

yes

@wolf4ood
Copy link
Collaborator

Hi @51yu

I think the main issue is the heartbeat handling which is still missing,
There where a PR in draft i can pick it from there and finish the work ASAP

Thanks

@51yu
Copy link
Author

51yu commented Feb 20, 2023

Meanwhile, could we mitigate the issue by letting producer periodically publish dummy message to stream and let consumer ignore that ? - convince broker, producer is still alive

@wolf4ood
Copy link
Collaborator

The best workaround it would be to disable the heartbeat, but from client side it's is not exposed yet. I would wait for this fix, I think it could be available tomorrow :)

wolf4ood added a commit that referenced this issue Feb 21, 2023
wolf4ood added a commit that referenced this issue Feb 21, 2023
@wolf4ood
Copy link
Collaborator

@51yu

I've opened the PR Waiting for the review and then it should fix this issue

Thanks

wolf4ood added a commit that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants