Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement heartbeat #141

Closed
wants to merge 3 commits into from
Closed

Conversation

akloboucnik
Copy link
Contributor

@akloboucnik akloboucnik commented Oct 6, 2022

@wolf4ood wolf4ood mentioned this pull request Feb 21, 2023
@michaelklishin
Copy link
Member

@akloboucnik from our experience with heartbeat implementations in other clients (not just RabbitMQ Stream Protocol ones), it is notoriously difficult to integration test. I'd be happy to test this PR, perhaps do a bit of renaming and try to get it over the line.

Would that be OK with you?

@wolf4ood
Copy link
Collaborator

wolf4ood commented Apr 3, 2023

@michaelklishin

this was stalled and basically the worked has been finished here

#163

Let in case let me know if you have time to test it :)

@michaelklishin
Copy link
Member

@wolf4ood ah, I see. So this should be closed then.

@Gsantomaggio
Copy link
Member

@wolf4ood we can close this, right?

@akloboucnik
Copy link
Contributor Author

@michaelklishin Sorry, I had to move on working on more pressing things at work and never got back to this :-(

@wolf4ood Thank you for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants