This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Include user in access logs #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Jan 3, 2020
|
Awesome, we just need to make sure we don't forget to rename |
michaelklishin
added a commit
that referenced
this pull request
Jan 3, 2020
Include user in access logs (cherry picked from commit e4bf110)
michaelklishin
added a commit
that referenced
this pull request
Jan 3, 2020
Include user in access logs (cherry picked from commit e4bf110)
michaelklishin
added a commit
that referenced
this pull request
Jan 3, 2020
This reverts commit 64fb5e5. This includes an OAuth 2-specific part so we should not do it.
|
Backported to |
|
Will this change address the "login" part of this request? |
|
If management is configured to write access logs then the access logs will include the user for all relevant requests, but there is no log indicating the user just logged in (because the credentials are sent with every request so it's like you log in every time). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the management side of the fix for: rabbitmq/rabbitmq-management#760
As a bonus it will also work for the Web plugins when HTTP authentication is used.