Log filter not working on Ubuntu 20.04

[Megamouse]

Hi. I can't filter the svn log dialog on Ubuntu 20.04.

I am sure that it worked on my older Ubuntu 16.04 install.
But since we upgraded our workstations to Ubuntu 20.04 at work, I can't filter anymore.
I can't even click the input field, which means I can't enter any text.
The Limit input field works though, so maybe it helps for debugging:

My setup:

[AlexFolland]

I'm seeing the same issue in Manjaro 20.2 running Nemo. Clicking the search field does nothing.

On top of that, pressing the up arrow key or down arrow key with a log entry highlighted doesn't update the selected log entry, so I have to click each log entry as a workaround.

Also, the text in the list of log entries is black on a dark background here, so reading it is literally painful.

These 3 issues together make RabbitVCS extremely unwieldly to use to search in SVN history in my project which has tens of thousands of commits.

RabbitVCS has the potential to be a great project and even come close to catching up with TortoiseSVN if these issues are resolved. Thanks for all your voluntary work on it.

[JorisHansMeijer]

Hi All,
I had the same problem. However I found a solution:

1. In the python source change the xml file: rabbitvcs/ui/xml/log.xml remove line 319 (can_focus propety for search_buffer),
2. In the file rabbitvcs/ui/log.py change line 194
   from: self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter()).lower()
   to: self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter(), 0).lower()

That is all :)

[metal450]

Hi All,
I had the same problem. However I found a solution:

1. In the python source change the xml file: rabbitvcs/ui/xml/log.xml remove line 319 (can_focus propety for search_buffer),

2. In the file rabbitvcs/ui/log.py change line 194
   from: self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter()).lower()
   to:     self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter(), 0).lower()

That is all :)

Awesome, I can confirm that this fixes the ability to search!

If u have the ability, it would be amazing to also have a fix for:

On top of that, pressing the up arrow key or down arrow key with a log entry highlighted doesn't update the selected log entry, so I have to click each log entry as a workaround.

:)

[JorisHansMeijer]

I have found a fix for this issue as well. You can find it in the pull requests section.

…

On vr, apr 16, 2021 at 13:00, metal450 ***@***.***> wrote: > Hi All, > I had the same problem. However I found a solution: > > 1. In the python source change the xml file: > rabbitvcs/ui/xml/log.xml remove line 319 (can_focus propety for > search_buffer), > > 2. In the file rabbitvcs/ui/log.py change line 194 > from: self.filter_text = tb.get_text(tb.get_start_iter(), > tb.get_end_iter()).lower() > to: self.filter_text = tb.get_text(tb.get_start_iter(), > tb.get_end_iter(), 0).lower() > That is all :) > Awesome, I can confirm that this fixes the ability to search! If u have the ability, it would be amazing to also have a fix for: > On top of that, pressing the up arrow key or down arrow key with a > log entry highlighted doesn't update the selected log entry, so I > have to click each log entry as a workaround. > :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIYDKPVEO5NHF4YKNG6M2CLTJCJOPANCNFSM4TDPHY7A>.

[metal450]

Nice, it works!!!

I know this isn't related, but since it seems you're pretty familiar with the codebase, I wonder if you might take a quick peek at #258? It's the only remaining day-to-day major issue, that Rabbit is never able to delete/remove files from Git. To delete anything requires explicitly doing so from the cli, then one can return to rabbit for other (working) features. If it's feasible, would be super awesome. Literally the only remaining broken thing I'm aware of :)

[CloCkWeRX]

Thanks @JorisHansMeijer for the fix!

[Megamouse]

I just saw that this was merged.
Works very well now after manually updgrading.
I'm also glad you guys fixed the keyboard navigation in the commit list.
Thanks guys 👍