Fix logwindow search/filter #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix call to get_text, it has 3 parameters now
Fix the can focus property of the search box in the log window
The font color was always set to black, even when using the os dark theme. However in this case the text was no longer readable.
Fix text color when activating the os dark theme
Megamouse
reviewed
Apr 16, 2021
| @@ -191,7 +195,7 @@ def on_refresh_clicked(self, widget): | |||
|
|
|||
| def on_search(self, widget): | |||
| tb = self.get_widget("search_buffer") | |||
| self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter()).lower() | |||
| self.filter_text = tb.get_text(tb.get_start_iter(), tb.get_end_iter(),0).lower() | |||
|
Doh, clicked the wrong button. Could you rebase this off current master; to avoid merging in extra fixes around dark mode? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the filter option for the log window (rabbitvcs log).