Fix nautilus 43 support #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
For the commented out code, I'd be happy to merge if you either put in a comment referring to this PR and the need to replace IconFactory; then nuked the commented out stuff; or put it as an inline explanation |
|
I removed the icon factory code completely, in my opinion it is not really needed. The distribution package has to install the icons into the icon structure and it will be found automatically by rabbitvcs. I also uncommented the property page code again, everything seems to work. I just did these commits with rabbitvcs-nautilus on Ubuntu 22.10 with Nautilus 43 and pushed them. |
CloCkWeRX
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR works again with Nautilus 43, replacement for Gtk.IconFactory still missing, PropertyPage disabled for now.