Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix related to concurrent write to map issue #35

Closed

Conversation

dheerajv4855
Copy link

tested it locally for around two hours by frequently changing the channels
working good now , didn't see any crash after changes

@rabilrbl
Copy link
Owner

rabilrbl commented Sep 9, 2023

Hey @dheerajv4855, Thanks for the PR,

I wish you had seen my other PR migrating to gofiber #30 and waited for my reply in #31
gofiber is built on top of fasthttp, similar to gin built on top net/http, hence fasthttp is an alternative to net/http, So i migrated from net/http to fasthttp. fasthttp performs well on concurrency. But net/http is better with standards, which is not relevant in our small application.

Secondly, r.Run(":5001") requires firewall permission everytime you run on windows, because you are exposing the port to public and less secure. Hence I had put localhost:5001 and added optional argument to set host:port

Unfortunately, I won't be able to merge this PR.

Thanks again!

@rabilrbl rabilrbl closed this Sep 9, 2023
@dheerajv4855
Copy link
Author

dheerajv4855 commented Sep 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants