New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__pthread_tpp_change_priority: Assertion failed #345
Comments
inconvenient day for https://gitlab.freedesktop.org to be down 😆 |
Attempt to reproduce raboof/notion#345
I linked notion to libX11 1.8.1 in raboof/nixpkgs@bb8ba82 but that did not reproduce the problem. Verified it does link to libX11 1.8.1:
... but works normally. Can anyone reproduce this and provide a backtrace? |
/cc @weinholt |
Here's the backtrace. I noticed now that it doesn't crash like this every time, but when it doesn't crash it instead hides all windows and doesn't respond to any commands.
|
Okay... so apparently it's happening while processing the graphics engine ( This is well after Any ideas? |
Could you perhaps try explicitly calling |
I've now tried calling I rebuilt notion with this patch: --- notion-4.0.2+dfsg.orig/ioncore/ioncore.c
+++ notion-4.0.2+dfsg/ioncore/ioncore.c
@@ -485,6 +485,7 @@ static bool ioncore_init_x(const char *d
*/
assert(!called);
called=TRUE;
+ XInitThreads();
/* Open the display. */
dpy=XOpenDisplay(display); Recall that notion sometimes fails with an assertion and other times it just hangs. I've captured a backtrace from notion when it just hanged:
|
Aha, so that suggests the problem might not have anything to do with https://gitlab.freedesktop.org/xorg/lib/libx11/-/commit/afcdb6fb0045c6186aa83d9298f327a7ec1b2cb9 after all? Definitely 'something with threads and mutexes' though - and still something we'd want to fix, of course.
Thanks a lot, that at least gives us something to go on :). So it's also happening in the graphics engine initialization ( I'm afraid I won't be able to dig much deeper right now, I'm rather busy the coming weeks - would be great if you could hunt it down further! |
I don't think this is a bug in notion. I think the problem is that libX11 uses pthreads but is not built with -pthread. I've written up my findings here: https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/157#note_1499394 |
Thanks a lot for the analysis. I guess there's nothing we can do from the Notion side - it would be nice if we could detect the problem and warn about it specifically, but even that sounds like it'd be a challenge. Hopefully this issue gets indexed by search engines and provides a good hint for other people running into this problem :) Feel free to re-open when you think of something we could do from the Notion side. |
originally reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016363#15
Rebuilding libx11 with the new
--disable-thread-safety-constructor
flag reportedly makes notion work again.The text was updated successfully, but these errors were encountered: