Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create knn class #1

Closed
rabutler-usbr opened this issue Nov 30, 2018 · 2 comments
Closed

create knn class #1

rabutler-usbr opened this issue Nov 30, 2018 · 2 comments

Comments

@rabutler-usbr
Copy link
Owner

  • try and ensure it doesn't conflict with other knn package classes
  • this is the output of the disagg function
@rabutler-usbr
Copy link
Owner Author

rabutler-usbr commented Dec 11, 2018

For now will call it:

knnst
stdisagg

rabutler-usbr added a commit that referenced this issue Dec 11, 2018
- `knn_space_time_disagg()` returns a `knnst` object
- added `knnst_index_years()`
- added `knnst_nsim()`
- added `is_knnst()`
- fixed the `write()` function
    - renamed to `write_knnst()`
- updated tests to expect the `knnst` object

working on #1
@rabutler-usbr
Copy link
Owner Author

rabutler-usbr commented Dec 11, 2018

Still need

  • tests for new knnst helper functions
  • knnst documentation
  • print.knnst()

rabutler-usbr added a commit that referenced this issue Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant