Bug/keyerror href #168
Merged
Bug/keyerror href #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add into options "tabindex" to togleButton - add into options "tabIndex" to transcript
-add property editable_fields
z4y4ts
approved these changes
Mar 20, 2017
Codecov Report
@@ Coverage Diff @@
## dev #168 +/- ##
==========================================
- Coverage 69.77% 69.72% -0.06%
==========================================
Files 25 25
Lines 1489 1493 +4
Branches 9 9
==========================================
+ Hits 1039 1041 +2
- Misses 448 450 +2
Partials 2 2
Continue to review full report at Codecov.
|
xahgmah
approved these changes
Mar 20, 2017
|
|
||
| Defaults to concatenation of `basic_fields` and `advanced_fields`. | ||
| """ | ||
| return tuple(itertools.chain(self.basic_fields, self.advanced_fields)) |
There was a problem hiding this comment.
What about tuple(set(self.basic_fields) | set(self.advanced_fields))?
Without external libraries, more clear
There was a problem hiding this comment.
Well, this solution will require converting two tuples into sets. Althought, my bet is we're not going to notice a performance difference with the data we use.
As for readability, both options look similar to me.
Also, itertools is part of Python's stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.