Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustc-ap crates to 670 #1123

Closed
wants to merge 1 commit into from
Closed

Conversation

tmandry
Copy link

@tmandry tmandry commented Jul 24, 2020

@tmandry
Copy link
Author

tmandry commented Jul 24, 2020

CI failure looks spurious (due to rust-lang/rustup#2434). I ran a build locally and it succeeded.

@calebcartwright
Copy link
Contributor

We've just about finished the process to get things fixed using v669, and bumping to v670 will require us to start the process all over again. Things are compiling fine for me using v669 with rustc 1.47.0-nightly (0820e54a8 2020-07-23), so is there anything specific needed in v670 that's worth the added delay?

If not I'd really prefer to see the bumps with v669 through to completion first

@tmandry
Copy link
Author

tmandry commented Jul 24, 2020

Sorry, I misunderstood the problem. I'll close this for now because I also want to get things green again.

If there's anything I can do to help with that, I'd be happy to :)

@tmandry tmandry closed this Jul 24, 2020
@tmandry tmandry deleted the rustc-ap-670 branch July 24, 2020 05:02
@calebcartwright
Copy link
Contributor

No worries! All that's left now is bumping the rustfmt and racer versions in rls, and then updating the two submods in rust-lang/rust.

Not sure if that'll be done via rust-lang/rls#1689 or a different one @Xanewok may be working on

@Xanewok
Copy link
Collaborator

Xanewok commented Jul 25, 2020

rust-lang/rls#1689 is now merged, sorry for the wait :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants