This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
fix ill formatted http Authorization string #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with python3, the NTLM Authorization string is of byte type. when concatenate it with the prefix, python adds b'' around the authorization string. for example, instead of generating: Authorization: NTLM TlRMTVNTUAABAAAAB7IIogoACgAyBBBBCgAKACgBBBBFASgKAAAAD1NISVktUDlYNzlOVklESUEuQ09N as would by python-ntlm, python-ntlm3 generated: Authorization: NTLM b'TlRMTVNTUAABAAAAB7IIogoACgAyBBBBCgAKACgBBBBFASgKAAAAD1NISVktUDlYNzlOVklESUEuQ09N' this resulted in server rejection (http 400 bad request)
|
my change failed automation. I'm using ubuntu 16 with python 3.5. The failure was with python 3.3. I don't have the environment to test it. |
|
This commit fixed my problem! It needs to be committed ASAP. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with python3, the NTLM Authorization string is of byte type.
when concatenating it with the prefix, python adds b'' around the authorization string.
for example, instead of generating:
Authorization: NTLM TlRMTVNTUAABAAAAB7IIogoACgAyBBBBCgAKACgBBBBFASgKAAAAD1NISVktUDlYNzlOVklESUEuQ09N
as would by python-ntlm,
python-ntlm3 generated:
Authorization: NTLM b'TlRMTVNTUAABAAAAB7IIogoACgAyBBBBCgAKACgBBBBFASgKAAAAD1NISVktUDlYNzlOVklESUEuQ09N'
this resulted in server rejection (http 400 bad request)