Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge cache_key if response headers do not include content digest #22

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

evman182
Copy link
Contributor

No description provided.

@ioquatix
Copy link
Member

Looks good to me! @olleolleolle any chance you can help me with a detailed review?

@evman182
Copy link
Contributor Author

@olleolleolle anything else pending on this?

@olleolleolle
Copy link
Contributor

@evman182 Thanks for asking!

I had to reconstruct the "why do we do this?", and my reconstitution of it is: "We purge bodies for which the response was not created with an x-content-digest, because these bodies have not been through the right way of construction."

Is that a nearly-correct way of expressing the reasoning for the change?

@evman182
Copy link
Contributor Author

@olleolleolle it's already purigng the meta entries if the bodies don't exist for the x-content-digest values. This will additionally purge the meta entries if they don't contain an x-content-digest value in the first place, which, to your point, means the meta entry wasn't constructed correctly.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your helpful PR!

@ioquatix ioquatix merged commit 4344620 into rack:main Feb 28, 2024
31 of 33 checks passed
@evman182
Copy link
Contributor Author

evman182 commented Mar 1, 2024

Would it be possible to cut a release?

@ioquatix
Copy link
Member

ioquatix commented Mar 1, 2024

Yes, I have been working on that.

@ioquatix ioquatix added this to the v1.16.0 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants