Remove 'uninitialized @digest_username' warning.

[tgxworld]

Related Tests: https://travis-ci.org/rails/rails/jobs/36882244

When a test returns a status of 401, the following methods will be called:

# test.rb

def retry_with_digest_auth?(env)
  last_response.status == 401 &&
  digest_auth_configured? &&
  !env["rack-test.digest_auth_retry"]
end

def digest_auth_configured?
  @digest_username
end

However, if digest_authorize is not called by the tests, we will get this warning warning: instance variable @digest_username not initialized

# Set the username and password for HTTP Digest authorization, to be
# included in subsequent requests in the HTTP_AUTHORIZATION header.
#
# Example:
#   digest_authorize "bryan", "secret"
def digest_authorize(username, password)
  @digest_username = username
  @digest_password = password
end

[tgxworld]

@brynary Could you have a look at this? Thanks in advance!

[whatyouhide]

👍 This should be merged IMO!

[cpetschnig]

Adding this would really be helpful, especially since RSpec 3.5 has warnings turned on by default:

# This setting enables warnings. It's recommended, but in some cases may
# be too noisy due to issues in dependencies.
config.warnings = true

rack-test is far too popular to have such mentioned issues ;-)

[dentarg]

Using the following in my specs for now, but would love to see this merged and released.

spec_help/warning_filter.rb:

# frozen_string_literal: true

# Inspired by https://github.com/rkh/tool
require "delegate"
class WarningFilter < DelegateClass(IO)
  def write(line)
    super unless silence?(line)
  end

  private

  VARIABLES_TO_IGNORE_PER_GEM = {
    # can be removed if https://github.com/brynary/rack-test/pull/116 is merged
    "rack-test" => %w[
      digest_username
    ],
    "rack-timeout" => %w[
      logger
      runner
      cancelled
    ],
  }

  VARIABLES_TO_IGNORE = VARIABLES_TO_IGNORE_PER_GEM
    .flat_map { |_gem_name, variables_to_ignore| variables_to_ignore }
    .join("|")

  def silence?(line)
    [
      /warning: instance variable @(#{VARIABLES_TO_IGNORE}) not initialized/,
      /assigned but unused variable - offset/,
    ].any? { |r| r =~ line }
  end
end

spec_helper.rb:

require_relative "spec_help/warning_filter"

# Replace stderr with our filtered class
$stderr = WarningFilter.new($stderr)

[dennissivia]

Implemented by PR #141

[junaruga]

@tgxworld thank your for your pull-request.
It was merged as 2178498 .