Feature/pr 125 add support for empty arrays in params #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make it easier to merge other pull requests, we should update to rspec 3. This PR updats the Gemfile.lock to use rspec 3.4, it also updats the test syntax to match the new rspec testing style. This Change has been ported from [this contribution](https://github.com/brynary/rack-test/pull/134/commits)
Update to latest rspec version and syntax.
Thanks to davidcelis. Implements: [PR 132](#132)
…tent-type-for-deletes Do not set Content-Type for DELETE requests.
Implements [PR 133](https://github.com/brynary/rack-test/pull/133/files)
…-testing Improve Cookie testing.
expose Rack::Test::Utils methods as module functions to avoid a mixing requirement of utility functions. Implements PR #131. Thanks to @tenderlove for implementing this feature.
…tipart-work-without-include Make `build_multipart` work without mixing in Rack::Test::Utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for empty arrays in params.
Without the patch empty arrays will be removed implicitly.
Adding this special case to
build_nested_queryfixes this issue.Implements PR #125, thanks to @croeck and @Timsly