Improve performance and flexibility of Rack::Utils.escape_html

rack · Jun 13, 2010 · b4d0dc7 · b4d0dc7 · sferik · Apr 26, 2011
1 parent 4bfb6fc
commit b4d0dc7
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -128,13 +128,18 @@ def build_nested_query(value, prefix = nil)
     end
     module_function :build_nested_query
 
+    ESCAPE_HTML = {
+      "&" => "&amp;",
+      "<" => "&lt;",
+      ">" => "&gt;",
+      "'" => "&#39;",
+      '"' => "&quot;",
+    }
+    ESCAPE_HTML_PATTERN = Regexp.union(ESCAPE_HTML.keys)
+
     # Escape ampersands, brackets and quotes to their HTML/XML entities.
     def escape_html(string)
-      string.to_s.gsub("&", "&amp;").
-        gsub("<", "&lt;").
-        gsub(">", "&gt;").
-        gsub("'", "&#39;").
-        gsub('"', "&quot;")
+      string.to_s.gsub(ESCAPE_HTML_PATTERN){|c| ESCAPE_HTML[c] }
     end
     module_function :escape_html