Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling in MethodOverride #1005

Closed
troelskn opened this issue Jan 26, 2016 · 2 comments
Closed

Better error handling in MethodOverride #1005

troelskn opened this issue Jan 26, 2016 · 2 comments

Comments

@troelskn
Copy link

This commit: 9a4140a made a change to suppress parse errors in the MethodOverride middleware. I suppose this is fine in production, but I just spent half a day tracking down why my rails app was ignoring _method and treating tunnelled PATCH requests as POST. In order to save some other poor soul from the same ill fate, I would suggest to log a warning of some kind when this happens - or perhaps fall back on a less strict parser (not sure how good an idea that is though).

@jeremyevans
Copy link
Contributor

This seems like a useful feature. Let's continue the conversation in #1019.

@ioquatix
Copy link
Member

ioquatix commented Feb 5, 2020

@jeremyevans I love your optimism "Let's continue the conversation" on a 4 year old issue. Thank you for being so gracious :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants