Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NULL byte in multipart file name #1115

Merged
merged 1 commit into from Sep 28, 2016
Merged

Handle NULL byte in multipart file name #1115

merged 1 commit into from Sep 28, 2016

Conversation

casperisfine
Copy link
Contributor

Rack 1.x was handling those just fine.

Rack 2.x blow up with:

    ArgumentError: string contains null byte
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:11 in `extname`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:11 in `in `block in <class`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:137 in `call`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:137 in `on_mime_head`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:262 in `handle_mime_head`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:215 in `block in run_parser`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:208 in `loop`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:208 in `run_parser`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:191 in `on_read`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart/parser.rb:70 in `parse`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/multipart.rb:52 in `extract_multipart`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/request.rb:472 in `parse_multipart`
    ~/.gem/ruby/2.2.3/gems/rack-2.0.1/lib/rack/request.rb:335 in `POST`

What is happening is that File.extname internally convert the ruby string to a C string, and C strings can't contain NULL bytes.

cc @rafaelfranca @kirs

@rafaelfranca
Copy link
Collaborator

LGTM

@tenderlove tenderlove merged commit 7dd7646 into rack:master Sep 28, 2016
eileencodes pushed a commit that referenced this pull request May 8, 2017
…-byte

Handle NULL byte in multipart file name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants