fix String status check failed at STATUS_WITH_NO_ENTITY_BODY #1275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
STATUS_WITH_NO_ENTITY_BODY
is an array of Integer, the check at lib/rack/lint.rb and lib/rack/content_length.rb allows to check the String status by callingto_i
, but other places do not.For example:
rack/lib/rack/content_type.rb
Lines 22 to 24 in ab00830
Fixed to allow String status for:
Resolves #1218