Fix use with kwargs
#1505
Merged
Fix use with kwargs
#1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails also has similar issue and is already fixed in rails/rails#38091.
|
Thanks! |
walro
added a commit
to walro/sinatra
that referenced
this pull request
May 28, 2021
The added test case would, prior to the fix, fail, under Ruby 3.0, with the following error: ``` MiddlewareTest#test_handles_keyword_arguments_0: ArgumentError: wrong number of arguments (given 2, expected 1) ``` The change itself was inspired by rack/rack#1505
walro
added a commit
to walro/sinatra
that referenced
this pull request
May 28, 2021
The added test case would, prior to the fix, fail, under Ruby 3.0, with the following error: ``` MiddlewareTest#test_handles_keyword_arguments_0: ArgumentError: wrong number of arguments (given 2, expected 1) ``` The change itself was inspired by rack/rack#1505
jkowens
pushed a commit
to sinatra/sinatra
that referenced
this pull request
Jun 2, 2021
The added test case would, prior to the fix, fail, under Ruby 3.0, with the following error: ``` MiddlewareTest#test_handles_keyword_arguments_0: ArgumentError: wrong number of arguments (given 2, expected 1) ``` The change itself was inspired by rack/rack#1505
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails also has similar issue and is already fixed in
rails/rails#38091.