Make Request#params not rescue EOFError #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no indication why this was done originally, and it is possible that it will rely in silent data loss. Fixes rack#761
|
Looks good to me. Seems CHANGELOG includes unrelated changes? |
|
Yes, I was fixing the wording of a previous CHANGELOG entry. |
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
bschmeck
added a commit
to bschmeck/grape
that referenced
this pull request
Feb 9, 2021
In v2.2.0, Rack started raising an EOFError when given an empty body with a multipart upload - rack/rack#1572 Previously, Rack had swallowed this error.
|
This caused ruby-grape/grape#2161, was this the right decision to make this change here? |
|
I think so. Silently ignoring errors is a bad idea. Looks like @ioquatix agreed. Not sure how other committers feel about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no indication why this was done originally, and it is
possible that it will rely in silent data loss.
Fixes #761