Change SPEC to not allow uppercase header keys #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update CHANGELOG with other spec changes made since 2.2. Implements rack#1592
ioquatix
approved these changes
Feb 19, 2022
|
Fixing external tests seems straight forward so I don't think this should be a blocker. However, I'd suggest we merge this and then clean up the remaining external issues. Once we confirm the direction, it won't be hard to sort out the downstream dependencies. |
This was referenced Feb 22, 2022
|
Okay @jeremyevans all external tests are passing. Falcon was already 100% compatible :) |
|
@tenderlove do you have any reservations regarding this? |
No, I think this is great. Thanks for doing this work @jeremyevans!! |
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 8, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
mishina2228
added a commit
to mishina2228/web-console
that referenced
this pull request
Jun 9, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
patrickm68
added a commit
to patrickm68/web-console
that referenced
this pull request
Dec 1, 2022
The latest rack 3.0 (unreleased) does not accept uppercase headers. See rack/rack#1592 for more details. refs: - rack/rack#1812 - rails/sprockets#744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update CHANGELOG with other spec changes made since 2.2.
Implements #1592
External tests are broken because this is a huge breaking change. If we are sure that we want this, we should disable the external CI jobs until the related projects have been fixed.