Extract rackup command, Rack::Server, Rack::Handler and related code into a separate gem.
#1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
extract-rackup
branch
2 times, most recently
from
5153e96
to
709d841
Compare
jeremyevans
reviewed
Aug 3, 2022
There was a problem hiding this comment.
As stated previously, I don't think the benefits of extracting rackup outweigh the backwards compatibility breakage. However, since we've decided to move in that direction, in terms of implementation, this looks mostly fine.
Can you explain why Rack::Handler#{register,[]} were left? Is it because web servers use those and you don't want to break that? If so, shouldn't both issue deprecation warnings? Ultimately, setting of handlers is for the benefit of rackup, not rack itself, if I understand things correctly. So we would want the webservers to check Rack.release and:
- For >= 3, if they want to support rackup, switch to
Rackup::Handler(if only defined, or attempting to require first and defining only if successful?). If they don't want to support rackup, do nothing. - For < 3, continue using
Rack::Handler.
ioquatix
force-pushed
the
extract-rackup
branch
from
5752b86
to
867b23c
Compare
jeremyevans
approved these changes
Aug 4, 2022
ioquatix
changed the title
rackup command, Rack::Server, Rack::Handler and related code into a separate gem.
dentarg
added a commit
to dentarg/rack
that referenced
this pull request
Sep 7, 2022
Does not work since the rackup extraction (rack#1937).
ioquatix
pushed a commit
that referenced
this pull request
Sep 9, 2022
Does not work since the rackup extraction (#1937).
ElMassimo
pushed a commit
to ElMassimo/jekyll-vite
that referenced
this pull request
Sep 9, 2022
Related to rack/rack#1937
stbenjam
added a commit
to stbenjam/origin
that referenced
this pull request
Sep 13, 2022
This test is failing in CI: ``` [sig-builds][Feature:Builds][Slow] s2i build with environment file in sources Building from a template should create a image from "test-env-build.json" template and run it in a pod [apigroup:build.openshift.io][apigroup:image.openshift.io] ``` In rack/rack#1937, rackup was moved to a different gem, which is what the s2i ruby config relies on: https://github.com/sclorg/s2i-ruby-container/blob/master/2.2/s2i/bin/assemble#L52 This adds "rackup" gem.
This was referenced Sep 13, 2022
stbenjam
added a commit
to stbenjam/origin
that referenced
this pull request
Sep 13, 2022
This test is failing in CI: ``` [sig-builds][Feature:Builds][Slow] s2i build with environment file in sources Building from a template should create a image from "test-env-build.json" template and run it in a pod [apigroup:build.openshift.io][apigroup:image.openshift.io] ``` In rack/rack#1937, rackup was moved to a different gem, which is what the s2i ruby config relies on: https://github.com/sclorg/s2i-ruby-container/blob/master/2.2/s2i/bin/assemble#L52 This adds "rackup" gem.
|
Should have never took the lobster out
|
|
Can you share some of the example code that uses this? |
blooper05
added a commit
to blooper05/LGTuMblr-api
that referenced
this pull request
Oct 13, 2022
… separate gem in Rack 3.0 refs. rack/rack#1937
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/origin
that referenced
this pull request
Oct 19, 2022
This test is failing in CI: ``` [sig-builds][Feature:Builds][Slow] s2i build with environment file in sources Building from a template should create a image from "test-env-build.json" template and run it in a pod [apigroup:build.openshift.io][apigroup:image.openshift.io] ``` In rack/rack#1937, rackup was moved to a different gem, which is what the s2i ruby config relies on: https://github.com/sclorg/s2i-ruby-container/blob/master/2.2/s2i/bin/assemble#L52 This adds "rackup" gem.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/origin
that referenced
this pull request
Oct 19, 2022
This test is failing in CI: ``` [sig-builds][Feature:Builds][Slow] s2i build with environment file in sources Building from a template should create a image from "test-env-build.json" template and run it in a pod [apigroup:build.openshift.io][apigroup:image.openshift.io] ``` In rack/rack#1937, rackup was moved to a different gem, which is what the s2i ruby config relies on: https://github.com/sclorg/s2i-ruby-container/blob/master/2.2/s2i/bin/assemble#L52 This adds "rackup" gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed the options here and the general consensus seems to be to extract it. #1928
This PR removes all the rackup specific code into https://github.com/rack/rackup
I've released a v0.1.0 gem for testing, and confirmed it works with this branch.
The following classes were moved:
Rack::Server->Rackup::ServerRack::Handler->Rackup::Handler. Some minimal function was retained for compatibility.Rack::Lobster->Rackup::Lobster.I've moved almost all the code verbatim with minimal changes.
There are several follow up actions but I suggest we make this as direct lift and shift as possible. Later on we can improve
rackupindependently ofrack.