Backport "Fix some unused variable verbose warnings" #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
referenced
this pull request
Jun 13, 2023
jeremyevans
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
@headius You may want to look at the JRuby failures here, could be related to the jzlib changes in JRuby 9.4.3.0.
ioquatix
approved these changes
Jun 14, 2023
|
@skipkayhil do you want me to cut a patch release from this? |
That would be awesome! Since Rails is testing against Rack 3 by default now that would help a lot with the warning noise |
|
Okay released, if you can also make a PR updating the change log that would be awesome. |
This was referenced Jun 14, 2023
I opened one for both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
/usr/local/bundle/gems/rack-3.0.7/lib/rack/sendfile.rb:114: warning: assigned but unused variable - status